feat(golems): add reusable join-code enrollment for bot onboarding#7
Merged
feat(golems): add reusable join-code enrollment for bot onboarding#7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR establishes the first Hive-side slice of the bot integration contract.
It changes enrollment from a one-time bootstrap secret into a reusable, revocable, TTL-bound join token, returns a copy-ready join code for
golemcore-bot, and documents the cross-repo contract that the bot implementation will follow.What Changed
Reusable enrollment tokens
registrationCount,lastUsedAt, andlastRegisteredGolemIdinstead of treating the token as single-useCopy-ready join codes for bot onboarding
POST /api/v1/enrollment-tokensnow returns both the raw token and a ready-made join code in the format<TOKEN>:<URL>hive.fleet.public-base-urlwhen configured, with a safe request-derived fallback otherwiseUI updates for operators
Contract and config documentation
docs/bot-integration-contract.mdto freeze the Hive ↔ bot integration model for join codes, config authority, machine session state, and bot-facing endpointsSPEC.mdto align the product spec with reusable tokens, read-only managed Hive config in the bot, and the join-code-based onboarding flowhive.fleet.public-base-urlto application config examples so operators can generate externally valid join codesVerification
./mvnw testcd ui && nvm use && npm run testcd ui && nvm use && npm run buildNotes