Skip to content

fix(slack): publish installable 1.0.2 settings compatibility release#21

Merged
alexk-dev merged 2 commits intomainfrom
feat/slack-plugin-1.0.2
Mar 18, 2026
Merged

fix(slack): publish installable 1.0.2 settings compatibility release#21
alexk-dev merged 2 commits intomainfrom
feat/slack-plugin-1.0.2

Conversation

@alexk-dev
Copy link
Owner

Summary

  • fix Slack plugin settings deserialization when stored config contains the legacy configured field
  • stop persisting computed configured back into plugin config on save
  • publish golemcore/slack 1.0.2 so installed runtimes receive the fix via the registry

Root cause

The settings read path deserialized persisted plugin config directly into SlackPluginConfig. Older stored payloads already contained a UI/computed field named configured, but SlackPluginConfig did not ignore unknown fields. That caused 400 responses when opening or saving Slack settings.

Changes

  • add @JsonIgnoreProperties(ignoreUnknown = true) to SlackPluginConfig
  • add @JsonIgnore to isConfigured() so the computed flag is not written back into stored plugin config
  • add a regression test for reading legacy config and saving normalized config without configured
  • bump the Slack plugin release to 1.0.2

Verification

  • mvn -pl golemcore/slack -am -Dtest=SlackPluginConfigServiceTest,SlackPluginConfigTest,SlackPluginSettingsContributorTest,SlackAdapterTest,SlackPlanApprovalAdapterTest,SlackConfirmationAdapterTest -Dsurefire.failIfNoSpecifiedTests=false test
  • python3 scripts/plugins_repo.py validate

@alexk-dev alexk-dev merged commit 996d853 into main Mar 18, 2026
4 checks passed
@alexk-dev alexk-dev deleted the feat/slack-plugin-1.0.2 branch March 18, 2026 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant