Skip to content

Fix InPlaceRestartMember: add run() method and remove EnsembleManager from restart ensemble #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 2 commits into
base: copilot/replace-restart-member-to-inplace
Choose a base branch
from
Draft

Fix InPlaceRestartMember: add run() method and remove EnsembleManager from restart ensemble #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
88bcbfb
Initial plan
Copilot Mar 27, 2026
c0af691
Add run() method to InPlaceRestartMember and remove EnsembleManager f…
Copilot Mar 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 15 additions & 3 deletions compass/landice/tests/ensemble_generator/sgh_restart_ensemble/restart_member.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@

import os

from compass.model import run_model
from compass.step import Step


Expand Down Expand Up @@ -40,8 +41,8 @@ class InPlaceRestartMember(Step):

Rather than copying files to a new directory, this step operates directly
in the original run directory. It sets ``config_do_restart = .true.`` in
``namelist.landice`` so that the run continues from its last checkpoint
when ``job_script.sh`` is resubmitted by ``EnsembleManager``.
``namelist.landice`` and then runs MALI to continue from the last
checkpoint.

Attributes
----------
Expand Down Expand Up @@ -80,7 +81,8 @@ def __init__(self, test_case, run_num, spinup_work_dir):
def setup(self):
"""
Edit ``namelist.landice`` in-place in the original run directory,
setting ``config_do_restart = .true.``.
setting ``config_do_restart = .true.``, and register the MALI
executable as an input for this step.

No files are copied and no new subdirectories are created.
"""
Expand All @@ -98,3 +100,13 @@ def setup(self):

print(f'Setting config_do_restart = .true. in {namelist_path}')
_set_restart_in_namelist(namelist_path)

# Register MALI executable so compass knows this step needs the model
self.add_model_as_input()

def run(self):
"""
Run MALI in the original run directory to continue the simulation
from its last checkpoint.
"""
run_model(self)
9 changes: 0 additions & 9 deletions compass/landice/tests/ensemble_generator/sgh_restart_ensemble/test_case.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,6 @@
import json
import os

from compass.landice.tests.ensemble_generator.ensemble_manager import (
EnsembleManager,
)
from compass.testcase import TestCase

from .restart_member import InPlaceRestartMember
Expand All @@ -43,9 +40,6 @@ def __init__(self, test_group):
name = 'sgh_restart_ensemble'
super().__init__(test_group=test_group, name=name)

# Add the ensemble manager (handles job submission)
self.add_step(EnsembleManager(test_case=self))

def configure(self):
"""
Configure restart ensemble by identifying incomplete runs.
Expand Down Expand Up @@ -122,9 +116,6 @@ def configure(self):

self.restart_run_numbers = restart_runs

# Only run ensemble_manager; it submits individual restart jobs
self.steps_to_run = ['ensemble_manager']

def _should_restart_run(
self,
run_dir,
Expand Down