Conversation
Signed-off-by: WAB <alexbendella1@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this does
Corrects the
RefPatterngrammar doc ingit_perms.rs, which described thegrammar as only literals and single
*and said "No**" — even though**(recursive wildcard) is a supported, tested feature. Also adds a unit test for
the
*-then-**combination (refs/*/**), which had no coverage.Why
The grammar docs mislead contributors: reading them you'd think
refs/heads/**is invalid, when it's implemented, documented on
matches(), and tested.How to test
cargo test -p buzz-core git_perms— the newpattern_wildcard_before_recursive_wildcardtest passes and no existing tests change. Doc-only otherwise;
cargo doc -p buzz-corestill builds.Notes
No behavior change — parser and matcher untouched; only a doc comment and one
additive test. Followed the existing doc style in this file. No existing open PR found.