who mnows#131
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: deff608e1b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| // Handle scenery change from tablet | ||
| const handleSceneryChange = useCallback((scenery: SceneryOption) => { | ||
| if (scenery.type === 'splat') { | ||
| if (!performanceFlags.allowSplats) { | ||
| return; | ||
| } | ||
| setUseGaussianSplat(true); | ||
| setSelectedSplat(scenery.path); | ||
| } else { | ||
| setUseGaussianSplat(false); | ||
| if (scenery.type === 'image') { | ||
| onChangeImage(scenery.path); |
There was a problem hiding this comment.
When a user selects a world of type splat from the Scene gallery (WorldGallery gets these from /api/backgrounds whenever /public/splats exists), handleSceneryChange now ignores anything that isn’t image, so the selection becomes a no-op: the gallery transition completes and the world is marked visited, but the background never changes. This is a functional regression for splat worlds. Either filter out splat entries upstream or restore splat handling here so selections actually switch scenes.
Useful? React with 👍 / 👎.
1 participant
No description provided.