Codex-generated pull request#171
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c884432b21
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| const GaussianSplatBackground: React.FC<GaussianSplatBackgroundProps> = ({ | ||
| splatUrl, | ||
| position = [0, 0, 0], | ||
| rotation = [0, 0, 0], |
There was a problem hiding this comment.
rotation = [0, 0, 0] allocates a fresh array on every render, and the current caller in ThreeSixty.tsx:522-525 also passes position={[0, 0, 0]} inline. Because those arrays are included in the effect dependencies here, any rerender tears down the existing DropInViewer scene and calls addSplatScene() again. Once setReady(true) resolves, the next render immediately re-enters the effect, so the Gaussian background can flicker or get stuck in a reload loop whenever this mode is active.
Useful? React with 👍 / 👎.
1 participant
Codex generated this pull request, but encountered an unexpected error after generation. This is a placeholder PR message.
Codex Task