Added graphql language#185
Merged
alexwforsythe merged 2 commits intoalexwforsythe:masterfrom Aug 3, 2022
Merged
Conversation
amomchilov
reviewed
Jul 18, 2022
Contributor
|
@alexwforsythe Any chance you can take a look into merging this? |
|
Please, I need this! |
meteren1990
approved these changes
Aug 2, 2022
Owner
alexwforsythe
left a comment
alexwforsythe
left a comment
There was a problem hiding this comment.
Looks good -- will approve once the formatting & naming comments are addressed!
|
V pumped for this. |
Co-authored-by: Alexander Momchilov <amomchilov@users.noreply.github.com>
alexwforsythe
approved these changes
Aug 3, 2022
Contributor
|
@alexwforsythe Hey Alex, do you have any plans for when you'd cut a new release that contains this? Funny enough, I have a tech design review on Monday, I would love to format my GraphQL blocks for it :D |
Contributor
Author
|
on the subject, #216 needs to be approved for this PR to work correctly as currently the name of the function we're calling is different from the name of the function we wrote |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #171.
Highlight.js does not add new languages anymore, and instead encourages 3rd parties to develop their own packages that they will link to from here Supported Languages.
From the official docs:
Therefore, to add support in
code-blocksfor new languages, packages for those languages will have to be explicitly pulled.In this PR I've defined a function in which other languages can also be added in the future, add added
graphqlin there.