Adapt Category getAllMembers to use queryGen#38
Adapt Category getAllMembers to use queryGen#38brianckeegan wants to merge 2 commits intoalexz-enwp:masterfrom
Conversation
| @@ -1,4 +1,4 @@ | |||
| # -*- coding: utf-8 -*- | |||
| # -*- coding: utf-8 -*- | |||
There was a problem hiding this comment.
Apparently in December 2008, byte order marks (U+FEFF) were added to files for "utf-8": 8708055.
|
@alexz-enwp: Any thoughts on this pull request? Do we still need the byte order marks? It'd be real nice to get rid of the bare except here (https://github.com/alexz-enwp/wikitools/pull/38/files#diff-330719e502db51fe8082141888459f62L114). I think wikitools is currently swallowing a legitimate error. :-/ Tangentially, I keep meaning to help out with this repo, but there are certain aspects I don't understand well enough that are tripping me up. I don't know when to increment the version number (I think we're currently at 1.3 or 1.4) or whether I should be touching the version number at all. I also don't know how to get https://pypi.python.org/pypi/wikitools updated. |
|
I don't know what the purpose of the byte order marks is... For this pull request, it would be nice to clean up this code (and I've done that in the major overhaul branch I'm working on 151ba06). But this change looks like it inadvertently drops the ability to get the results as page objects vs titles. |
3 participants
No description provided.