Skip to content

Fix: setup_payout_account returns error flash instead of Stripe Connect redirect (#274) #310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Ishant5436 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix: setup_payout_account returns error flash instead of Stripe Connect redirect (#274) #310

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions lib/algora/payments/payments.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -303,14 +303,14 @@ defmodule Algora.Payments do
end
end

@spec create_account_link(account :: Account.t(), base_url :: String.t()) ::
@spec create_account_link(account :: Account.t(), base_url :: String.t(), type :: String.t()) ::
{:ok, PSP.account_link()} | {:error, PSP.error()}
def create_account_link(account, base_url) do
def create_account_link(account, base_url, type \\ "account_onboarding") do
PSP.AccountLink.create(%{
account: account.provider_id,
refresh_url: "#{base_url}/callbacks/stripe/refresh",
return_url: "#{base_url}/callbacks/stripe/return",
type: "account_onboarding"
type: type
})
end

Expand Down
4 changes: 3 additions & 1 deletion lib/algora_web/live/org/transactions_live.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,9 @@ defmodule AlgoraWeb.Org.TransactionsLive do
end

def handle_event("setup_payout_account", _params, socket) do
case Payments.create_account_link(socket.assigns.account, AlgoraWeb.Endpoint.url()) do
type = if socket.assigns.account.details_submitted, do: "account_update", else: "account_onboarding"

case Payments.create_account_link(socket.assigns.account, AlgoraWeb.Endpoint.url(), type) do
{:ok, %{url: url}} -> {:noreply, redirect(socket, external: url)}
{:error, _reason} -> {:noreply, put_flash(socket, :error, "Something went wrong")}
end
Expand Down
4 changes: 3 additions & 1 deletion lib/algora_web/live/user/transactions_live.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,9 @@ defmodule AlgoraWeb.User.TransactionsLive do
end

def handle_event("setup_payout_account", _params, socket) do
case Payments.create_account_link(socket.assigns.account, AlgoraWeb.Endpoint.url()) do
type = if socket.assigns.account.details_submitted, do: "account_update", else: "account_onboarding"

case Payments.create_account_link(socket.assigns.account, AlgoraWeb.Endpoint.url(), type) do
{:ok, %{url: url}} ->
{:noreply, redirect(socket, external: url)}

Expand Down