Fix login 404/500 errors by validating last_context#311
Open
Ishant5436 wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #183, fixes #186, fixes #302. When a user's previous context (e.g. personal organization handle) is changed or deleted, their session or database
last_contextmight still refer to the old handle. This caused thesigned_in_pathto redirect to a 404 page (or 500 error) immediately upon login, preventing them from accessing the app. This PR ensures thatlast_contextis validated against the database before redirecting, and falls back toAccounts.default_context()if the context no longer exists.