Skip to content

Minor Improvement in ProtoSmartBeta#1

Open
luongthanhanhduc wants to merge 1 commit intomainfrom
duc_review
Open

Minor Improvement in ProtoSmartBeta#1
luongthanhanhduc wants to merge 1 commit intomainfrom
duc_review

Conversation

@luongthanhanhduc
Copy link
Copy Markdown

Description

In this MR, Duc made some small changes in the repo:

  • Update the README to let people know that 3.12 is a better Python version to run this project. Duc failed to create Python virtual environment in this project with 3.13.
  • Update the optimization.py to write the optimized parameters directly to the file parameter/optimized_parameter.json
  • Remove a redundant section in the README file

Testing

Duc successfully ran the following commands:

python backtesting.py
python optimization.py
python evaluation.py

Copy link
Copy Markdown
Contributor

@khoi-ta khoi-ta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

APPROVED

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants