Skip to content

Add requiresFullScreen property and enhance iPad orientations #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
algotyrnt merged 2 commits into from
Mar 6, 2026
Merged

Add requiresFullScreen property and enhance iPad orientations #7

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
afec87c
Add requiresFullScreen property to Package.swift
algotyrnt Feb 28, 2026
467976a
Enhance supported interface orientations for iPad
algotyrnt Feb 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion Beacon.swiftpm/Package.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,10 @@ let package = Package(
.phone
],
supportedInterfaceOrientations: [
.portrait
.portrait,
.landscapeRight(.when(deviceFamilies: [.pad])),
.landscapeLeft(.when(deviceFamilies: [.pad])),
.portraitUpsideDown(.when(deviceFamilies: [.pad]))
Comment on lines 29 to +33
Copy link

Copilot AI Mar 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR title/description mention adding a requiresFullScreen property, but this diff only updates supportedInterfaceOrientations. Either add the requiresFullScreen change (if intended) or update the PR metadata so it accurately reflects the actual change set.

Copilot uses AI. Check for mistakes.
Comment on lines +30 to +33
Copy link

Copilot AI Mar 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indentation of the items in supportedInterfaceOrientations appears inconsistent with nearby arrays in this file. Please reformat this block to keep the manifest readable and consistent.

Suggested change
.portrait,
.landscapeRight(.when(deviceFamilies: [.pad])),
.landscapeLeft(.when(deviceFamilies: [.pad])),
.portraitUpsideDown(.when(deviceFamilies: [.pad]))
.portrait,
.landscapeRight(.when(deviceFamilies: [.pad])),
.landscapeLeft(.when(deviceFamilies: [.pad])),
.portraitUpsideDown(.when(deviceFamilies: [.pad]))

Copilot uses AI. Check for mistakes.
],
Comment on lines 29 to 34
Copy link

Copilot AI Mar 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is made in an auto-generated manifest (see the warning at the top of this file). Any regeneration step (e.g., from Xcode/Swift Playgrounds) is likely to overwrite these orientation updates. Please apply this change in the source that generates Beacon.swiftpm/Package.swift (or document/update the generation workflow) so it persists.

Copilot uses AI. Check for mistakes.
capabilities: [
.bluetoothAlways(purposeString: "Bluetooth allows Beacon to form an offline emergency network with nearby devices."),
Expand Down