Fix multiple bugs in distributed utils, SpatialTransformer, and diffusion schedules#162
Open
Mr-Neutr0n wants to merge 1 commit intoali-vilab:mainfrom
Open
Fix multiple bugs in distributed utils, SpatialTransformer, and diffusion schedules#162Mr-Neutr0n wants to merge 1 commit intoali-vilab:mainfrom
Mr-Neutr0n wants to merge 1 commit intoali-vilab:mainfrom
Conversation
…sformer proj_out dims, linear_schedule typo - Fix DiffScatter class having duplicate 'symbolic' method instead of 'forward' - Fix reduce_dict missing parentheses on input_dict.keys call - Fix SpatialTransformer proj_out Linear dimensions being swapped when use_linear=True - Fix linear_schedule typo 'ast_beta' that should be 'last_beta'
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
utils/distributed.py): TheDiffScatterclass had two methods both namedsymbolic, so the second one overwrote the first, leaving noforwardmethod. Renamed the secondsymbolictoforward.utils/distributed.py):keys = list(input_dict.keys)referenced the method object instead of calling it. Added parentheses:input_dict.keys().tools/modules/unet/util.py): Whenuse_linear=True,proj_outwas initialized asnn.Linear(in_channels, inner_dim)but it should project frominner_dimback toin_channels. Fixed tonn.Linear(inner_dim, in_channels).tools/modules/diffusions/schedules.py):ast_beta = last_beta or scale * 0.02assigned to a dead variable instead of updatinglast_beta. Fixed tolast_beta = last_beta or scale * 0.02.Test plan
DiffScatter.apply()works correctly in distributed settingsreduce_dictworks withOrderedDictinputsSpatialTransformerwithuse_linear=Trueproduces correct output dimensionslinear_scheduleuses the computed default value forlast_beta