Skip to content

update version#46

Closed
oxmmty wants to merge 2 commits intomasterfrom
dev
Closed

update version#46
oxmmty wants to merge 2 commits intomasterfrom
dev

Conversation

@oxmmty
Copy link
Copy Markdown

@oxmmty oxmmty commented Jan 26, 2026

No description provided.

@oxmmty oxmmty requested a review from HLXEasy January 28, 2026 16:06
@oxmmty oxmmty self-assigned this Jan 28, 2026
@HLXEasy
Copy link
Copy Markdown
Member

HLXEasy commented Feb 4, 2026

The whole change was done with a single commit. That's a bad practice as it's impossible to modify the changes on this branch easily.

@HLXEasy
Copy link
Copy Markdown
Member

HLXEasy commented Feb 4, 2026

I've added a bunch of notes regarding changes which only modify the copyright header. But as that's a lot of files I'd like to suggest to setup a new branch, which only contains real code changes. Additionally these changes should be split into separate commits, if that's possible.

So please update the copyright header only on files, which contain other changes ("real changes"), to prevent complex and huge diffs in the future.

@HLXEasy
Copy link
Copy Markdown
Member

HLXEasy commented Mar 25, 2026

Hey @oxmmty

It seems you did not really get what I explained with my comment above. It makes no sense to fix the headers within all the files with a second commit! If this PR gets merged, it will produce two commits on the main branch. The first one will modifiy nearly everything and the second commit reverts most of the changes.

So please create a complete new branch and perform only the required changes there! Additionally it would be very much appreciated, if that's not only one single commit as it makes it easier to get the idea of the changes. But that's up to you.

I'll close this PR as it makes no sense to continue here.

@HLXEasy HLXEasy closed this Mar 25, 2026
@oxmmty
Copy link
Copy Markdown
Author

oxmmty commented Mar 25, 2026 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants