Conversation
|
The whole change was done with a single commit. That's a bad practice as it's impossible to modify the changes on this branch easily. |
|
I've added a bunch of notes regarding changes which only modify the copyright header. But as that's a lot of files I'd like to suggest to setup a new branch, which only contains real code changes. Additionally these changes should be split into separate commits, if that's possible. So please update the copyright header only on files, which contain other changes ("real changes"), to prevent complex and huge diffs in the future. |
|
Hey @oxmmty It seems you did not really get what I explained with my comment above. It makes no sense to fix the headers within all the files with a second commit! If this PR gets merged, it will produce two commits on the main branch. The first one will modifiy nearly everything and the second commit reverts most of the changes. So please create a complete new branch and perform only the required changes there! Additionally it would be very much appreciated, if that's not only one single commit as it makes it easier to get the idea of the changes. But that's up to you. I'll close this PR as it makes no sense to continue here. |
|
Hi Helix,
Thanks for the clarification
I understand your point now.
I will update
… Message ID: ***@***.***
.com>
|
No description provided.