fix(chore): install clang in rpm-build.sh for building agentsight#107
Open
Daydreamer-Li wants to merge 1 commit intoalibaba:mainfrom
Open
fix(chore): install clang in rpm-build.sh for building agentsight#107Daydreamer-Li wants to merge 1 commit intoalibaba:mainfrom
Daydreamer-Li wants to merge 1 commit intoalibaba:mainfrom
Conversation
Fixes alibaba#75: install clang automatically before cargo build to resolve 'failed to execute clang' error on systems without clang in PATH. Signed-off-by: liyuqing <liyuqing@alibaba-inc.com>
samchu-zsl
changed the title
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
samchu-zsl
reviewed
Apr 8, 2026
Collaborator
samchu-zsl
left a comment
samchu-zsl
left a comment
There was a problem hiding this comment.
Using package managers other than dnf/yum in rpm-build scripts lacks legitimacy. Please provide the background for these changes.
samchu-zsl
dismissed
their stale review
The reasonableness of this change needs to be reconsidered.
casparant
approved these changes
Apr 8, 2026
samchu-zsl
requested changes
Apr 9, 2026
Collaborator
samchu-zsl
left a comment
samchu-zsl
left a comment
There was a problem hiding this comment.
This script is only compatible with RPM-based distributions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #75: install clang automatically before cargo build to resolve 'failed to execute clang' error on systems without clang in PATH.
Description
Related Issue
closes # #75
Type of Change
Scope
cosh(copilot-shell)agent-sec-coreos-skillsagentsightChecklist
cosh: Lint passes, type check passes, and tests passagent-sec-core(Rust):cargo clippy -- -D warningsandcargo fmt --checkpassagent-sec-core(Python): Ruff format and pytest passos-skills: Skill directory structure is valid and shell scripts pass syntax checkpackage-lock.json/Cargo.lock)Testing
Additional Notes