Add gdsfactory replication steps - #8
Open
gkielian wants to merge 2 commits into
Open
Conversation
Utilizing ${HOME} in place of /home/$(logname), for home directory.
This will make the script more general.
Formatted spaces to 4 spaces, using spaces instead of tabs.
Removed trailing forwardslash from paths.
Added double quotes "" for bash to guard against word splitting and
globbing in the case that any variables have wildcard or space
characters.
Author
|
Would these steps look correct so far? Also which are the subsequent steps for replication? |
gkielian
force-pushed
the
add_gdsfactory_replication_steps
branch
from
November 10, 2023 01:05
d022d53 to
3514660
Compare
gkielian
force-pushed
the
add_gdsfactory_replication_steps
branch
from
November 10, 2023 02:50
3514660 to
3694b20
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Creating a getting started section within the top level README
Wanted to make sure to log the steps.
Eventually we can compress these steps into a script a reviewer can run with one command line invocation.