Addition of protein ribbon + ligand rendering#96
Open
JamesOBrien2 wants to merge 8 commits intoaligfellow:mainfrom
Open
Addition of protein ribbon + ligand rendering#96JamesOBrien2 wants to merge 8 commits intoaligfellow:mainfrom
JamesOBrien2 wants to merge 8 commits intoaligfellow:mainfrom
Conversation
Contributor
Author
|
I swear a lot of the code line additions are just the .pdb files 🫣 |
…d-rendering-and-halo # Conflicts: # src/xyzrender/cli.py # src/xyzrender/renderer.py # tests/test_cli.py
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addition of protein ribbon + ligand rendering, additional highlight style (halo), ligand highlighting, protein-ligand NCI visualisation, and mmCIF rendering/handling (This would however, require a specific fork of ASE, potentially better to stash this for the time being).
What’s Included
Added/updated protein ribbon rendering pipeline and semantics integration.
Protein styles simplified to:
gloss(default for--protein)illustrationAdded/standardized ligand UX:
--highlight-ligandfor ligand highlighting--halo ligandfor ligand highlighting (halo)--ligand-colorfor ligand highlight styling--nci-ligandfor ligand-protein NCIsRenderer behavior:
--ghosts) for better performanceCIF/mmCIF protein semantics path improved in parser/reader flow to preserve metadata for SS handling.
Added/updated tests across CLI/API/protein/highlight/semantics paths.
Added README and example assets for:
Why
This consolidates the recent protein/ligand work into one coherent user-facing experience with consistent CLI semantics, better defaults, and more reliable protein+NCI output quality.
Dependency
Part of this PR depends on the
xyzgraphprotein semantics PR (feature/protein-semantics-foundation):Part of this PR depends on the
asemmCIF file-format reader PR (feature/mmcif-reader).