Skip to content

feat(adk.sessions.v1): added display name to file data#2

Open
AndrewMurdoch-Alis wants to merge 2 commits into
mainfrom
filedata
Open

feat(adk.sessions.v1): added display name to file data#2
AndrewMurdoch-Alis wants to merge 2 commits into
mainfrom
filedata

Conversation

@AndrewMurdoch-Alis

Copy link
Copy Markdown

No description provided.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces an optional display_name field to the FileData message in sessions.proto. The review feedback suggests a minor improvement to the comment style and grammar of the new field to ensure consistency with the rest of the file.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment on lines +482 to +483
// Optional: the display name of the files
string display_name = 3;

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The comment style and grammar should be consistent with the rest of the file. Specifically, use a period instead of a colon after 'Optional', capitalize the description, and use the singular 'file' instead of 'files' since FileData represents a single file.

Suggested change
// Optional: the display name of the files
string display_name = 3;
// Optional. Display name of the file.
string display_name = 3;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant