feat(adk.sessions.v1): added display name to file data#2
feat(adk.sessions.v1): added display name to file data#2AndrewMurdoch-Alis wants to merge 2 commits into
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces an optional display_name field to the FileData message in sessions.proto. The review feedback suggests a minor improvement to the comment style and grammar of the new field to ensure consistency with the rest of the file.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| // Optional: the display name of the files | ||
| string display_name = 3; |
There was a problem hiding this comment.
The comment style and grammar should be consistent with the rest of the file. Specifically, use a period instead of a colon after 'Optional', capitalize the description, and use the singular 'file' instead of 'files' since FileData represents a single file.
| // Optional: the display name of the files | |
| string display_name = 3; | |
| // Optional. Display name of the file. | |
| string display_name = 3; |
No description provided.