Fixes for basic 5.0 printing support#21
Open
jvrobert wants to merge 1 commit intoalkaes:masterfrom
Open
Conversation
|
Hi @jvrobert, unfortunately your plugin version does not work for me. Qidi Print is displayed (in contrast to the original version), but it is an empty window afterwards and sending does not work. |
Author
|
To be clear, this is a very very limited patch. It only fixes (for me, at least) an existing, installed, and configured plugin. So I had the plugin working on 4.x, upgraded to 5, it broke - this lets me do the bare minimum (push a print to printer, but not monitor). Probably everything else including configuration etc.. still broken. So if you get it working on 4.x then upgrade and apply patch it will..probably ;) work..ok..enough. I may spend a little more time on a more full fledged patch soon. |
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Hi - this doesn't fix everything (and would break 4.x so that would need considered) but it does allow at least an existing, configured install of QidiPrint to work on Cura 5.0. I was able to push a print to the printer via network, but the monitoring doesn't work.