Skip to content

fix: increase table client max retries to 5#32

Merged
allanhvam merged 1 commit into
mainfrom
fix/table-client-max-retries
Nov 26, 2025
Merged

fix: increase table client max retries to 5#32
allanhvam merged 1 commit into
mainfrom
fix/table-client-max-retries

Conversation

@allanhvam
Copy link
Copy Markdown
Owner

No description provided.

@allanhvam allanhvam requested a review from Copilot November 26, 2025 08:57
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR increases the maximum retry attempts for Azure Table Storage client operations from the default to 5 retries, improving resilience against transient failures. The version is also bumped to 0.5.5.

  • Adds retry configuration with maxRetries: 5 for all TableClient instances
  • Applies the retry configuration to both connection string and credential-based initialization paths

Reviewed changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.

File Description
src/stores/DurableFunctionsWorkflowHistoryStore.ts Adds retry options to TableClient instantiation for both history and instances tables
package.json Bumps package version from 0.5.4 to 0.5.5

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +82 to +83
this.history = new TableClient(tableUrl, `${taskHubName}History`, credential, tableServiceClientOptions);
this.instances = new TableClient(tableUrl, `${taskHubName}Instances`, credential, tableServiceClientOptions);
Copy link

Copilot AI Nov 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The TableClient constructor signature appears incorrect. According to the Azure SDK, TableClient constructor takes (url, tableName, credential?, options?) but this code passes credential as the third parameter and options as the fourth. The credential and options parameters should be swapped or combined into the options object.

Copilot uses AI. Check for mistakes.
@allanhvam allanhvam merged commit 413fe63 into main Nov 26, 2025
1 check passed
@allanhvam allanhvam deleted the fix/table-client-max-retries branch November 26, 2025 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants