Make ModelDims.from_hf_config robust to explicit head_dim#1731
Open
hamishivi wants to merge 2 commits into
Open
Make ModelDims.from_hf_config robust to explicit head_dim#1731hamishivi wants to merge 2 commits into
hamishivi wants to merge 2 commits into
Conversation
Honor an explicit head_dim from HF configs (e.g. composite/VLM models) instead of always deriving it from hidden_size // num_attention_heads, and relax the __post_init__ assertion to require a positive head_dim. Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the model dimension configuration in open_instruct/utils.py to validate and compute head_dim from the Hugging Face configuration. The reviewer recommends replacing the assert statements with explicit ValueError exceptions to ensure robust runtime validation, as assertions can be optimized away when Python is run with optimization flags.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
farhatkevin
approved these changes
Jun 25, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to a conflict with the base branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
head_dimfrom HF configs (e.g. composite/VLM models) instead of always deriving it fromhidden_size // num_attention_heads, which fails whenhidden_sizeis not divisible bynum_attention_heads.__post_init__assertion to require a positivehead_dim.Test plan
GPU_TESTS=bypass
Made with Cursor