[Tech debt] Remove deprecated code#661
Open
robmarkcole wants to merge 4 commits into
Open
Conversation
Collaborator
|
Thanks, I agree this can be removed now, and agree about the tests being unnecessary. |
robmarkcole
changed the title
Collaborator
Author
|
Implemented_ removal of ALL the listed deprecated features. Removed compatibility paths for:
Also removed the related per_period_mosaic_reverse_time_order compatibility option because it only existed for the old period mosaic ordering behavior. |
…ed warnings - Removed `use_legacy_timestamps` parameter from OlmoEarth and related classes. - Updated timestamp handling to align with new implementation, ensuring compatibility with future versions. - Cleaned up deprecated code and warnings related to legacy timestamp handling across various modules. - Adjusted tests to reflect the removal of legacy timestamp functionality and ensure proper handling of current timestamp logic. - Removed deprecated parameters and functionality from SimpleTimeSeries and SelectBands transforms. - Updated dataset reading functions to eliminate reliance on deprecated time range extraction methods. - Cleaned up test cases to remove legacy compatibility checks and ensure alignment with current implementation.
Collaborator
|
I think we are not quite ready to remove these yet. |
Collaborator
Author
|
@favyen2 feel free to close this & reopen later as you see fit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As title. Tests may be overkill
There are many more deprecations that can be addressed: