feat: Add IDR Rate Aggregator with Frankfurter API and Strategy Pattern#218
Open
thasyalarasuci wants to merge 5 commits into
Open
feat: Add IDR Rate Aggregator with Frankfurter API and Strategy Pattern#218thasyalarasuci wants to merge 5 commits into
thasyalarasuci wants to merge 5 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Integrates Frankfurter API for latest IDR rates, historical IDR→USD, and supported currencies.
Uses Strategy Pattern for clean and extensible resource handling without conditional logic.
All data is loaded once at application startup and stored in a thread-safe immutable in-memory cache (no external API calls on request).
Exposes a single REST endpoint: /api/finance/data/{resourceType}.
Personalizes USD spread factor using GitHub username (thasyalarasuci).
Includes proper error handling for external API failures and unit tests using Mockito.
Follows clean architecture principles, separation of concerns, and all assignment requirements.