Add direct CLI attach#168
Merged
Merged
Conversation
almogdepaz
commented
Jul 11, 2026
almogdepaz
left a comment
Owner
Author
There was a problem hiding this comment.
ran review passes against main...pr/herdr-e-direct-cli-attach:
edc-reviewsecurity/adversarialedc-delivery-reviewgoal + architecture fitedc-auditquality/maintainabilityantipattern-scanchanged-region smell pass
verdict
- security: no new bypass found; attach stays through authenticated server
/ws/ptyrather than direct broker access. - delivery/architecture: delivered.
- quality/antipatterns: no blocking findings.
notes
- raw mode is gated behind interactive stdin/stdout checks and has an idempotent restorer.
- viewer conflict defaults to non-destructive exit and requires
--take-controlto displace. - prefill/live bytes come from the existing WS path, so this does not create a second terminal-history source.
- tests cover parsing, target resolution, close-code mapping, ws url jwt construction, handshake, resize, input, prefill, and default conflict refusal.
recommendation
approve from review standpoint. manual TTY smoke against a real broker is still worth doing before release, as the plan notes.
# Conflicts: # src/cli/index.ts
# Conflicts: # package.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Source plan:
.plans/e-direct-cli-attach.mdVerification
main.planstask artifact from the PR branch