Skip to content

Add plugin manifest discovery model#170

Open
almogdepaz wants to merge 3 commits into
mainfrom
pr/herdr-g-plugin-manifest-model
Open

Add plugin manifest discovery model#170
almogdepaz wants to merge 3 commits into
mainfrom
pr/herdr-g-plugin-manifest-model

Conversation

@almogdepaz

Copy link
Copy Markdown
Owner

Summary

  • add plugin manifest schema/discovery surfaces
  • add docs, UI/API/CLI wiring, and tests

Source plan: .plans/g-plugin-manifest-model.md

Verification

  • cherry-picked Ralph task commit onto fresh branch from main

@almogdepaz almogdepaz left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ran review passes against main...pr/herdr-g-plugin-manifest-model:

  • edc-review security/adversarial
  • edc-delivery-review goal + architecture fit
  • edc-audit quality/maintainability
  • antipattern-scan changed-region smell pass

verdict

  • security: no direct code-execution path found; manifests are data-only and not executed.
  • delivery/architecture: delivered for v1 discovery/listing/validation.
  • quality/antipatterns: acceptable, with one rollout caveat.

notes

  • manifest discovery rejects symlink traversal, caps file size, validates unknown fields, and labels trust/source.
  • UI rendering escapes plugin fields and only summarizes capabilities.
  • CLI/API expose listing and validation without executing plugin-declared commands/actions.

advisory

  • where: docs/plugin-manifests.md:4-10, src/cli/config.ts:31-45, src/server/routes.ts:436-446
  • issue: docs mention configured pluginDirs, but do not show the ~/.wolfpack/config.json shape or WOLFPACK_PLUGIN_DIRS env option that the implementation reads.
  • recommendation: add a tiny config example so users can actually exercise non-default plugin roots without reading source.

recommendation

approve after/with the docs tweak.

@almogdepaz

Copy link
Copy Markdown
Owner Author

addressed the review advisory in 7ac6742.\n\nwhat changed:\n- added docs for ~/.wolfpack/config.json pluginDirs\n- added docs for WOLFPACK_PLUGIN_DIRS colon-separated roots\n- added a docs regression assertion\n\nverification:\n- bun test tests/unit/plugin-manifest.test.ts\n- bun test\n- bun run typecheck\n\nreview status: finding was valid; fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant