Add plugin manifest discovery model#170
Open
almogdepaz wants to merge 3 commits into
Open
Conversation
almogdepaz
commented
Jul 11, 2026
almogdepaz
left a comment
Owner
Author
There was a problem hiding this comment.
ran review passes against main...pr/herdr-g-plugin-manifest-model:
edc-reviewsecurity/adversarialedc-delivery-reviewgoal + architecture fitedc-auditquality/maintainabilityantipattern-scanchanged-region smell pass
verdict
- security: no direct code-execution path found; manifests are data-only and not executed.
- delivery/architecture: delivered for v1 discovery/listing/validation.
- quality/antipatterns: acceptable, with one rollout caveat.
notes
- manifest discovery rejects symlink traversal, caps file size, validates unknown fields, and labels trust/source.
- UI rendering escapes plugin fields and only summarizes capabilities.
- CLI/API expose listing and validation without executing plugin-declared commands/actions.
advisory
- where:
docs/plugin-manifests.md:4-10,src/cli/config.ts:31-45,src/server/routes.ts:436-446 - issue: docs mention configured
pluginDirs, but do not show the~/.wolfpack/config.jsonshape orWOLFPACK_PLUGIN_DIRSenv option that the implementation reads. - recommendation: add a tiny config example so users can actually exercise non-default plugin roots without reading source.
recommendation
approve after/with the docs tweak.
Owner
Author
|
addressed the review advisory in 7ac6742.\n\nwhat changed:\n- added docs for ~/.wolfpack/config.json pluginDirs\n- added docs for WOLFPACK_PLUGIN_DIRS colon-separated roots\n- added a docs regression assertion\n\nverification:\n- bun test tests/unit/plugin-manifest.test.ts\n- bun test\n- bun run typecheck\n\nreview status: finding was valid; fixed. |
# Conflicts: # src/public-assets.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Source plan:
.plans/g-plugin-manifest-model.mdVerification
main