Improve somewhat on the test, plus a stab at working better with futures.#317
Closed
filiph wants to merge 2 commits intoalnitak:mainfrom
Closed
Improve somewhat on the test, plus a stab at working better with futures.#317filiph wants to merge 2 commits intoalnitak:mainfrom
filiph wants to merge 2 commits intoalnitak:mainfrom
Conversation
Owner
Collaborator
Author
|
Yeah, I think we can close this. There's some more logging here and possibly a solved edge case with closing a completer, but I'd rather work on #319 and see if it solves issues, and maybe resurrect this change as a nice-to-have followup. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Concerns #312