Conversation
bart1
reviewed
Apr 16, 2026
| { | ||
| "name": "radar_height", | ||
| "description": "Height of the center of the radar antenna in m above sea level. Constant for all records from the same `radar`.", | ||
| "type": "integer", |
There was a problem hiding this comment.
Suggested change
| "type": "number", |
If were updating anyway it might be worth changing this as I have some radars we have more detail on the radar. I think this only relaxes the standard and should be backward compatible
bart1
reviewed
Apr 16, 2026
bart1
left a comment
bart1
left a comment
There was a problem hiding this comment.
just a quick think I noticed as now I need to round down radar_height
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add optional
height_referencecolumn, addressing issue #49