app_mixmonitor: perform directional silence padding after both streams to avoid double-insert#1
Open
alonsoac wants to merge 1 commit intoasterisk-11.25.3from
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
fr_readandfr_writeboth contained frames in the same audiohook cycle and thus stretch recordings.Description
mixmonitor_threadto write all read frames and all write frames first (updating counters only after successfulast_writestreamcalls), and perform at most one balancing pad operation afterwards based on the final counter delta.struct mixmonitor_ds:read_samples_written,write_samples_written,read_silence_samples_inserted,write_silence_samples_inserted,read_silence_log_shown, andwrite_silence_log_shownto track totals and one-time logging.mixmonitor_write_silence()to emit zeroed frames in chunks andmixmonitor_samples_to_ms()to convert sample counts to milliseconds, and update end-of-recording logging to report totals.ast_writestreamfailure and only successful writes advance sample counters.Testing
make -j2 apps/app_mixmonitor.o, which failed because the source tree requires./configureto be run beforemake, so the build could not be completed in this environment.Codex Task