Conversation
Owner
|
Thanks for this! It looks like I won't be able to use rhub for checking with the new ggplot2, or do you know of a workaround? Thanks! |
Contributor
Author
|
Thanks for picking this up! I'd just install the development version locally and run R CMD check yourself. If your working directory is in the package, you can do: pak::pak("tidyverse/ggplot2")
devtools::check(remote = TRUE, manual = TRUE) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi there,
We've been preparing a new major release for ggplot2 and found an issue during a reverse dependency check.
We did not find a problem in qqplotr itself, but shared reverse dependencies implied there should be.
After a bit of head scratching, I finally found the culprit. The issue is that during package build time (e.g. on CRAN's machines), some of your ggproto classes capture (and fix) methods from ggplot2's ggproto classes. That means that if somebody updates ggplot2, they'd still be running the old methods in qqplotr, which can give version mismatches. Such version mismatches appeared in shared reverse dependencies.
The fix isn't too hard, we just need to make sure we call the method rather than to copy the method. This PR does that for the single method that was giving troubles.
You can test your code with the development version of ggplot2 by installing it as follows:
We aim to release the new ggplot2 version in about 2 weeks, and hope you can submit a fix to CRAN around that time. Hopefully this will inform you in a timely manner.
Best wishes,
Teun