Skip to content

Validate CWL when condition dependencies#825

Merged
GlassOfWhiskey merged 1 commit intomasterfrom
feat/check-condition-deps
Mar 27, 2026
Merged

Validate CWL when condition dependencies#825
GlassOfWhiskey merged 1 commit intomasterfrom
feat/check-condition-deps

Conversation

@LanderOtto
Copy link
Copy Markdown
Collaborator

This commit adds a check in the CWLTranslator to ensure that the inputs used in the when condition are defined as WorkflowStepInput.

@LanderOtto LanderOtto changed the title Validation condition dependencies Validate CWL when condition dependencies Oct 10, 2025
@GlassOfWhiskey GlassOfWhiskey force-pushed the master branch 7 times, most recently from b21f362 to e7820f1 Compare January 12, 2026 08:25
@GlassOfWhiskey GlassOfWhiskey force-pushed the master branch 4 times, most recently from 8c05dac to 4a6edc9 Compare January 24, 2026 13:16
…puts used in the `when` condition are defined as `WorkflowStepInput`.
@GlassOfWhiskey GlassOfWhiskey force-pushed the feat/check-condition-deps branch from 54cf60e to c9c4dba Compare March 27, 2026 18:08
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 27, 2026

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 74.35%. Comparing base (fd55312) to head (c9c4dba).
⚠️ Report is 1 commits behind head on master.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
streamflow/cwl/translator.py 0.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #825      +/-   ##
==========================================
- Coverage   74.37%   74.35%   -0.02%     
==========================================
  Files          90       90              
  Lines       12447    12449       +2     
  Branches     2179     2180       +1     
==========================================
  Hits         9257     9257              
- Misses       2676     2677       +1     
- Partials      514      515       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Copy Markdown
Member

@GlassOfWhiskey GlassOfWhiskey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GlassOfWhiskey GlassOfWhiskey merged commit e98b0b1 into master Mar 27, 2026
42 checks passed
@GlassOfWhiskey GlassOfWhiskey deleted the feat/check-condition-deps branch March 27, 2026 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants