Conversation
quis
force-pushed
the
remove-detailed-flag
branch
from
ed8538a to
6bb8e31
Compare
quis
force-pushed
the
remove-detailed-flag
branch
from
6bb8e31 to
039b223
Compare
klssmith
reviewed
Feb 9, 2026
Contributor
klssmith
left a comment
klssmith
left a comment
There was a problem hiding this comment.
This change looks good, though I noticed when reviewing this that the data the tests say that the get_service_templates endpoint no longer matches what it actually returns. That problem wasn't introduced here, but maybe if it's a quick fix it could be addressed here so we don't forget to do it later (if it takes more work I'm happy to approve this now instead and come back to it)
Member
Author
quis
force-pushed
the
remove-detailed-flag
branch
from
624696b to
d711088
Compare
klssmith
approved these changes
Feb 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is ignored as of https://github.com/alphagov/notifications-api/pull/4664/changes#diff-bda89c7cb0b4c7bc98a8e1661a4c26854c0588f71dd62ef9aecb04e3905c90fdL172-L175