Allow multiple workspaces per buffer#53
Draft
gagbo wants to merge 1 commit into
Draft
Conversation
37b4a04 to
fad3c20
Compare
Owner
|
FYI, I probably won't have time to look at this soon. Thanks for your patience. |
Owner
|
FYI, due to some IRL issues and computer problems, I haven't had time to work on Emacs stuff. It will probably be a while longer before I can look at this carefully. |
71a32f5 to
fdb8193
Compare
Author
|
Don't worry, living comes first. Actually I think I'll move the PR back to draft as I'm only starting using the features I'd like to add and I'm seeing a few bugs/usability issues that I'm fixing |
c8bb2a8 to
5fda7f5
Compare
Owner
|
Ok, thanks. Let me know when you're ready for it to be looked at again. |
Owner
|
For reference, this PR's ideas were previously discussed at #49. Thinking about this a bit more, I think what's needed is:
|
Owner
|
We should probably discuss these ideas in an issue rather than a PR, so: #69 |
5fda7f5 to
d5346b6
Compare
- Rename `bufler-workspace-name` to `bufler-workspace-names` to show it can hold multiple values - Add prefix to workspace names in the groups (as a defcustom) - Make `bufler-workspace-buffer-name-workspace` add to list of buffer-local workspace value instead of replacing it - Use another version of `seq-group-by` in `bufler-group-tree` that adds an element in multiple groups if the grouping function returns a list. - Add utility functions to access/manage named workspaces + Add function to list all buffers in a named workspace + Add function to clean up a single named workspace Co-authored-by: Adam Porter <adam@alphapapa.net>
d5346b6 to
3d3bb8c
Compare
9333643 to
84e837f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello again,
I hope this time I'll be clear enough, I tend to over-complicate things and I try to work on that :(
Rescoping the previous messy PR I made. The point is that here, we do not need non-consuming groups in order to allow multiple workspaces for a single buffer.
Feature summary
The workflow I want to cover is :
bufler-workspace-frame-set(bufler-workspace-buffer-name-workspace "Bufler")bufler-workspace-frame-set(bufler-workspace-buffer-name-workspace "Emacs Config")Then, if I list buffers with

M-x bufler, I want to see thebufler.elbuffer under 2 different named workspaces.Change summary
bufler-workspace-nametobufler-workspace-namesto show itcan hold multiple values
bufler-workspace-buffer-name-workspaceadd to list ofbuffer-local workspace value instead of replacing it
seq-group-byinbufler-group-treethat addsan element in multiple groups if the grouping function returns a list.
For the last point, it would be better to use
cl-defmethodto overridethe
seq-group-byfunction only when grouping workspaces but currentlyno version tried work. Last try :