small fixes for compiling with JUCE 5.4.7#8
Open
jyg wants to merge 1 commit intoaltalogix:masterfrom
jyg:master
Open
small fixes for compiling with JUCE 5.4.7#8jyg wants to merge 1 commit intoaltalogix:masterfrom jyg:master
jyg wants to merge 1 commit intoaltalogix:masterfrom
jyg:master
Conversation
As mentionned here stevefolta/SFZero#5 small modifications are needed in order to keep the library compiling with latest JUCE
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As mentionned here stevefolta/SFZero#5
small modifications are needed in order to keep the library compiling with latest JUCE
sfzero::Sound *sound = dynamic_cast<sfzero::Sound *>(getSound(0));
needs to be changed to:
sfzero::Sound *sound = dynamic_cast<sfzero::Sound *>(getSound(0).get());
occurrences of
juce::String::empty
need to be changed to
juce::String()