-
-
Notifications
You must be signed in to change notification settings - Fork 621
Accept Voice Memos drags and add batch file transcription #716
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
shreeraman96
wants to merge
17
commits into
main
Choose a base branch
from
feat/219-voicememo-batch
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
abafe64
feat: accept Voice Memos drags and batch file transcription (#219)
shreeraman96 30a04be
fix: deliver every item of a multi-memo drag; add batch UI screenshot
shreeraman96 41951be
fix: crash on multi-item promise drags — serialize pasteboard access
shreeraman96 e6137ea
fix: address xhigh code-review findings
shreeraman96 61f65b2
fix: hold dictation intent across every start, stop, and cancel path
shreeraman96 8457208
fix: sanitize promised file names and bound fallback deliveries
shreeraman96 e659501
fix: give every delivered promise file its own staging dir
shreeraman96 a7e75d8
fix: drop a cancelled transcription instead of writing it to history
shreeraman96 ebeec17
style: compress Voice Memos drop and batch comments
shreeraman96 a358531
fix: expect promised file names, not receivers, when bounding delivery
shreeraman96 b455632
style: cut branch comment density below 10% per file
shreeraman96 809f0f5
fix: survive an undecodable promise and stop stalling a lone drop
shreeraman96 c67a687
fix: keep partial receiver output and count legacy promise names
shreeraman96 5c07b86
fix: check the batch guard before flipping recording mode
shreeraman96 8057bd6
style: compress this branch's comments
shreeraman96 5cb1d04
fix: keep polling a receiver that is still writing past the soft timeout
shreeraman96 c44affd
fix: shorten the delivery wait once a receiver has completed
shreeraman96 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| #ifndef OBJC_EXCEPTION_CATCHER_H | ||
| #define OBJC_EXCEPTION_CATCHER_H | ||
|
|
||
| #import <Foundation/Foundation.h> | ||
|
|
||
| NS_ASSUME_NONNULL_BEGIN | ||
|
|
||
| /// Runs the block, returning a raised exception's description or nil if it completed. | ||
| /// Pasteboard and file-promise calls raise, and a C++ terminate handler in-process | ||
| /// turns any uncaught NSException into abort(). | ||
| NSString *_Nullable FluidCatchObjCException(void (NS_NOESCAPE ^block)(void)); | ||
|
|
||
| NS_ASSUME_NONNULL_END | ||
|
|
||
| #endif |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| #import "ObjCExceptionCatcher.h" | ||
|
|
||
| NSString *FluidCatchObjCException(void (NS_NOESCAPE ^block)(void)) { | ||
| @try { | ||
| block(); | ||
| return nil; | ||
| } @catch (NSException *exception) { | ||
| return exception.description ?: @"unknown Objective-C exception"; | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.