Skip to content

fix: preserve hidden Dock state on reopen #774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
postoso wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: preserve hidden Dock state on reopen #774

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions Sources/Fluid/AppDelegate.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,6 +128,10 @@ class AppDelegate: NSObject, NSApplicationDelegate, UNUserNotificationCenterDele
return true
}

// LaunchServices restores the bundle's default activation policy on an external reopen.
// Re-apply the saved preference before foregrounding the existing app (#753).
self.applyDockVisibilityPolicy()

// Ensure dock-icon reopen always foregrounds FluidVoice.
sender.activate(ignoringOtherApps: true)

Expand Down Expand Up @@ -179,8 +183,8 @@ class AppDelegate: NSObject, NSApplicationDelegate, UNUserNotificationCenterDele
}

/// Apply the user's dock-visibility preference ("Hide from dock", issue #162).
/// Re-applied after operations that can reset the process activation policy - notably the
/// LaunchServices reopen below, which restores the bundle default (.regular) even when the
/// Re-applied after operations that can reset the process activation policy - notably
/// LaunchServices reopens, which restore the bundle default (.regular) even when the
/// app is reopened without activation, so hide-from-dock is honored on login launches (#396).
private func applyDockVisibilityPolicy() {
NSApp.setActivationPolicy(SettingsStore.shared.showInDock ? .regular : .accessory)
Expand Down
Loading