Skip to content

Fix text insertion mode description wrapping - #791

Open
so1omon563 wants to merge 1 commit into
altic-dev:mainfrom
so1omon563:codex/issue-776-text-insertion-wrap
Open

Fix text insertion mode description wrapping#791
so1omon563 wants to merge 1 commit into
altic-dev:mainfrom
so1omon563:codex/issue-776-text-insertion-wrap

Conversation

@so1omon563

@so1omon563 so1omon563 commented Aug 5, 2026

Copy link
Copy Markdown

Description

Allow the Text Insertion Mode description to wrap instead of truncating at narrower Settings window widths. The text now takes the available leading space while the picker keeps its existing fixed width.

Type of Change

  • 🐞 Bug fix
  • ✨ New feature
  • 💥 Breaking change
  • 🧹 Chore
  • 📝 Documentation update

Related Issue or Discussion

Closes #776.

Testing

  • Tested on Intel Mac
  • Tested on Apple Silicon Mac
  • Tested on macOS version: 26.5.2
  • Ran linter locally: swiftlint --strict --config .swiftlint.yml Sources (SwiftLint is not installed locally)
  • Ran formatter locally: swiftformat --config .swiftformat Sources (SwiftFormat is not installed locally)
  • Ran tests locally: xcodebuild test -project Fluid.xcodeproj -scheme Fluid -destination 'platform=macOS,arch=arm64'

Also verified with swiftc -parse, git diff --check, and an unsigned app build.

Screenshots / Video

After: narrow Settings window with the full Text Insertion Mode description wrapped beside the picker.

Text Insertion Mode description wrapping at narrow window width
  • No UI/visual changes; screenshots/video are not applicable.

Notes

AI assistance: Codex was used for implementation and validation.

@github-actions

github-actions Bot commented Aug 5, 2026

Copy link
Copy Markdown

The PR Policy check is blocking this PR because required template information is missing.

Please update the PR description with:

  • Screenshots / Video

Visual files detected:

  • Sources/Fluid/UI/SettingsView.swift

Screenshots or video are required for UI, UX, settings, onboarding, overlay, menu bar, or visual behavior changes. If this PR has no visual changes, check the no-visual-change box in the template.

If this remains incomplete for 48 hours after opening, the PR may be closed.

@github-actions github-actions Bot added needs screenshots Pull request needs screenshot or video evidence. and removed needs screenshots Pull request needs screenshot or video evidence. labels Aug 5, 2026
@so1omon563
so1omon563 marked this pull request as ready for review August 5, 2026 16:05
@greptile-apps

greptile-apps Bot commented Aug 5, 2026

Copy link
Copy Markdown

Greptile Summary

This PR fixes the Text Insertion Mode settings row so its description uses the available leading space and wraps vertically while preserving the picker's fixed width.

  • Enables vertical wrapping for the mode description.
  • Expands and leading-aligns the description container.
  • Removes the redundant spacer between the description and picker.

Confidence Score: 5/5

The PR appears safe to merge, with the focused layout change preserving the fixed-width picker while allowing the description to wrap.

The modified row follows the established wrapping pattern used by sibling settings rows, and no concrete reachable layout failure remains.

Reviews (1): Last reviewed commit: "Fix text insertion mode description wrap..." | Re-trigger Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG]

1 participant