Adiciona checagem de CNPJ para saber se ele foi previamente formatado#65
Open
vmesel wants to merge 1 commit intoalvarofpp:mainfrom
Open
Adiciona checagem de CNPJ para saber se ele foi previamente formatado#65vmesel wants to merge 1 commit intoalvarofpp:mainfrom
vmesel wants to merge 1 commit intoalvarofpp:mainfrom
Conversation
alvarofpp
requested changes
Jul 31, 2024
Comment on lines
+43
to
+45
| if not self._validate_input(doc, ['.', '/', '-']): | ||
| # Documento previamente formatado | ||
| return doc |
Owner
There was a problem hiding this comment.
O _validate_input irá retornar True em casos como '1-.22/.33./44.4-55', pois ele verifica apenas os caracteres. Creio que o ideal seria aplicar um RegEx para verificar se doc atende ao padrão de CNPJ, algo como [0-9]{2}\.[0-9]{3}\.[0-9]{3}\/[0-9]{4}\-[0-9]{2}.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Caso você envie um CNPJ já formatado para o CNPJ().mask(), ele retorna um CNPJ totalmente errôneo. Este PR visa resolver isso colocando uma checagem anterior a formatação.