Skip to content

fix: support aggregate field dictionaries in get_list - #65

Merged
barredterra merged 2 commits into
version-16from
aggregate-queries
Jul 20, 2026
Merged

fix: support aggregate field dictionaries in get_list#65
barredterra merged 2 commits into
version-16from
aggregate-queries

Conversation

@barredterra

Copy link
Copy Markdown
Member

No description provided.

@greptile-apps

greptile-apps Bot commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

Confidence Score: 5/5

Safe to merge — the change is narrowly scoped to coerce_field_list and the type annotations around it, with a new test validating the happy path.

The refactor is straightforward: dict entries in the field list are now passed through unchanged, the Python 2-style except clause is corrected, and the test verifies the core scenario. No existing tests were removed, and the new behaviour is backward-compatible for callers that only pass string fields.

No files require special attention.

Reviews (2): Last reviewed commit: "fix: review issues" | Re-trigger Greptile

Comment thread ask_alyf/ask_alyf/toolset.py Outdated
Comment thread ask_alyf/ask_alyf/tools.py
@barredterra
barredterra merged commit ab0ca7a into version-16 Jul 20, 2026
5 checks passed
@barredterra

barredterra commented Jul 20, 2026

Copy link
Copy Markdown
Member Author

@Mergifyio backport version-15 develop

@barredterra
barredterra deleted the aggregate-queries branch July 20, 2026 19:47
@mergify

mergify Bot commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

backport version-15 develop

✅ Backports have been created

Details

Cherry-pick of ab0ca7a has failed:

On branch mergify/bp/version-15/pr-65
Your branch is up to date with 'origin/version-15'.

You are currently cherry-picking commit ab0ca7a.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   ask_alyf/ask_alyf/test_code_tools.py
	modified:   ask_alyf/ask_alyf/toolset.py

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   ask_alyf/ask_alyf/tools.py

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

barredterra added a commit that referenced this pull request Jul 20, 2026
…73)

Co-authored-by: Raffael Meyer <14891507+barredterra@users.noreply.github.com>
barredterra added a commit that referenced this pull request Jul 20, 2026
…72)

Co-authored-by: Raffael Meyer <14891507+barredterra@users.noreply.github.com>
This was referenced Jul 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant