fix: add ToolErrorMiddleware

[barredterra]

No description provided.

[greptile-apps]

Confidence Score: 5/5

Safe to merge — additive middleware wiring with a well-tested sanitisation callback, and the api.py hardening removes an information-leakage path.

All three agent entry points now wrap exceptions before they reach the model or the user. Sanitisation logic correctly separates intentional Frappe messages (exposed) from unexpected exceptions (type-name only), and the test suite explicitly exercises the secret-scrubbing path.

No files require special attention.

Sequence Diagram

%%{init: {'theme': 'neutral'}}%%
sequenceDiagram
    participant User
    participant api as api.py
    participant Runner as AgentRunner
    participant Agent as Coordinator
    participant MW as ToolErrorMiddleware
    participant Tool as Frappe Tool

    User->>api: HTTP request
    api->>Runner: run_message(...)
    Runner->>Agent: invoke
    Agent->>MW: wrap_tool_call
    MW->>Tool: handler(request)
    alt ValidationError or PermissionError
        Tool-->>MW: raises exc
        MW-->>Agent: "ToolMessage(status=error, detail)"
    else Unexpected Exception
        Tool-->>MW: raises exc
        MW-->>Agent: "ToolMessage(status=error, type-name only)"
    else Unhandled escape
        Agent-->>api: raises
        api->>api: log_error
        api-->>User: generic message
    end

Loading

%%{init: {'theme': 'base', 'themeVariables': {"darkMode": true, "background": "#0d1117", "primaryColor": "#21262d", "primaryTextColor": "#e6edf3", "primaryBorderColor": "#8b949e", "lineColor": "#8b949e", "textColor": "#e6edf3", "edgeLabelBackground": "#161b22", "actorBkg": "#21262d", "actorBorder": "#8b949e", "actorTextColor": "#e6edf3", "actorLineColor": "#8b949e", "signalColor": "#8b949e", "signalTextColor": "#e6edf3", "noteBkgColor": "#373320", "noteBorderColor": "#d4a72c", "noteTextColor": "#f0e6c0", "labelBoxBkgColor": "#21262d", "labelBoxBorderColor": "#8b949e", "labelTextColor": "#e6edf3", "loopTextColor": "#e6edf3", "activationBkgColor": "#30363d", "activationBorderColor": "#8b949e"}}}%%
sequenceDiagram
    participant User
    participant api as api.py
    participant Runner as AgentRunner
    participant Agent as Coordinator
    participant MW as ToolErrorMiddleware
    participant Tool as Frappe Tool

    User->>api: HTTP request
    api->>Runner: run_message(...)
    Runner->>Agent: invoke
    Agent->>MW: wrap_tool_call
    MW->>Tool: handler(request)
    alt ValidationError or PermissionError
        Tool-->>MW: raises exc
        MW-->>Agent: "ToolMessage(status=error, detail)"
    else Unexpected Exception
        Tool-->>MW: raises exc
        MW-->>Agent: "ToolMessage(status=error, type-name only)"
    else Unhandled escape
        Agent-->>api: raises
        api->>api: log_error
        api-->>User: generic message
    end

Loading

_{Reviews (2): Last reviewed commit: "fix: translate error messages" | Re-trigger Greptile}

[barredterra]

@Mergifyio backport version-15 develop

[mergify]

backport version-15 develop

✅ Backports have been created

Details

• #80 fix: add ToolErrorMiddleware (backport #76) has been created for branch version-15
• #81 fix: add ToolErrorMiddleware (backport #76) has been created for branch develop