week -3 task to be reviewed by amanrajs · Pull Request #3 · amanrajs/Week-tasks

amanrajs · 2019-07-25T09:45:15Z

No description provided.

mnhaque · 2019-07-28T17:26:26Z

Week-3/scripts/Render.js

+  }
+}
+function setLeftContent(fullContainer,container){
+  let url = `https://newsapi.org/v2/top-headlines?country=in&apiKey=ac1fd7a9fc1342abb913e554a9525d85&pageSize=20`;


move url to constant file

mnhaque · 2019-07-28T17:27:45Z

Week-3/scripts/constants.js

@@ -0,0 +1,17 @@
+const defaultContent='Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo consequat. Duis aute irure dolor in reprehenderit in voluptate velit esse cillum dolore eu fugiat nulla pariatur. Excepteur sint occaecat cupidatat non proident, sunt in culpa qui officia deserunt mollit anim id est laborum.';
+const defaultDescription='created at 21 July 2019""created at 21 July 2019';


can use single const declaration

mnhaque · 2019-07-28T17:27:57Z

Week-3/scripts/Utility.js

+    window.localStorage.setItem(emailid, JSON.stringify(emailid));
+    alert(emailSubscribedMessage);
+  }
+  else{


generally if else block is indented as below example

if(condition) { //code } else if(condition) { //code } else { //code }

mnhaque · 2019-07-28T17:28:11Z

Week-3/scripts/Utility.js

+      popup.appendChild(descriptionPopup);
+      fullContainer.style.opacity = '0.3';
+    }
+    else if(clickEvent.srcElement.id === 'closePopup'){


generally if else block is indented as below example

if(condition) { //code } else if(condition) { //code } else { //code }

mnhaque · 2019-07-28T17:28:33Z

Week-3/scripts/Update_View.js

+      btn.heading=contentHead;
+      }
+      else{
+      btn.data=data.articles[index].description;


generally if else block is indented as below example

if(condition) { //code } else if(condition) { //code } else { //code }

mnhaque · 2019-07-28T17:37:15Z

Week-3/scripts/Render.js

+  })
+  .catch(function(error) {
+  });
+  fullContainer.appendChild(container);


shouldnt be this line inside the success?

amanrajs · 2019-07-29T12:23:37Z

Week-3/scripts/Render.js

+  .catch(function(error) {
+  });
+  fullContainer.appendChild(container);
+  }


for this assignment trainer asked to keep in header only

mnhaque · 2019-07-28T17:40:42Z

Week-3/scripts/Render.js

@@ -0,0 +1,41 @@
+function setRightContent(article_data,fullContainer,container){
+  let rightContainer = document.createElement('div'),


fix indentation for this function

mnhaque · 2019-07-28T17:41:01Z

Week-3/scripts/Render.js

+  }
+}
+function setLeftContent(fullContainer,container){
+  let url = `https://newsapi.org/v2/top-headlines?country=in&apiKey=ac1fd7a9fc1342abb913e554a9525d85&pageSize=20`;


fix indentation for this function

mnhaque · 2019-07-28T17:41:42Z

Week-3/scripts/Update_View.js

+function changeContent(val,fullContainer,container){
+    let data=fullContainer.data;
+    let similar=0;
+    container.innerHTML = '';


fix indentation for this function

amanrajs · 2019-07-29T12:23:37Z

Week-3/scripts/Render.js

+  .catch(function(error) {
+  });
+  fullContainer.appendChild(container);
+  }


for this assignment trainer asked to keep in header only

mnhaque · 2019-08-04T10:25:12Z

Week-3/scripts/Render.js

@@ -0,0 +1,10 @@
+function setLeftContent(fullContainer,container,newsUrl){


fix indentation for the file

mnhaque · 2019-08-04T10:25:50Z

Week-3/scripts/Update_View.js

@@ -0,0 +1,78 @@
+function changeContent(container,fullContainer){


fix indentation for the file

mnhaque · 2019-08-04T10:26:11Z

Week-3/scripts/Utility.js

@@ -0,0 +1,40 @@
+function clicked(clickEvent,fullContainer,popup){
+return clickEvent => {


fix indentation for the file

mnhaque · 2019-08-10T00:30:59Z

looks good

29amansingh added 2 commits July 25, 2019 15:11

Signed-off-by: Aman Singh <aman_singh@epam.com>

e130a7f

updated week -3 tasks with code standarads

d7d4e26

mnhaque reviewed Jul 28, 2019

View reviewed changes

amanrajs commented Jul 29, 2019

View reviewed changes

29amansingh added 3 commits July 29, 2019 19:27

did the changes and optimised dom creation

fb515db

bug fix

4a8346b

USED SOURCES API TO DISPLAY NEWS FOR PARTICULAR NEWS CHANNEL

81c8567

mnhaque reviewed Aug 4, 2019

View reviewed changes

Indentation fixed

5bd34e1

		@@ -0,0 +1,17 @@
		const defaultContent='Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo consequat. Duis aute irure dolor in reprehenderit in voluptate velit esse cillum dolore eu fugiat nulla pariatur. Excepteur sint occaecat cupidatat non proident, sunt in culpa qui officia deserunt mollit anim id est laborum.';
		const defaultDescription='created at 21 July 2019""created at 21 July 2019';

		@@ -0,0 +1,41 @@
		function setRightContent(article_data,fullContainer,container){
		let rightContainer = document.createElement('div'),

		@@ -0,0 +1,10 @@
		function setLeftContent(fullContainer,container,newsUrl){

		@@ -0,0 +1,78 @@
		function changeContent(container,fullContainer){

		@@ -0,0 +1,40 @@
		function clicked(clickEvent,fullContainer,popup){
		return clickEvent => {

Conversation

amanrajs commented Jul 25, 2019

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mnhaque commented Aug 10, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants