Skip to content

refactor: clean code improvements #305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
raymond-julie wants to merge 1 commit into
base: development
Choose a base branch
from
Open

refactor: clean code improvements #305

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions app/src/main/java/com/git/amarradi/leafpad/adapter/CategoryAdapter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
package com.git.amarradi.leafpad.adapter;
private static final int STROKE_WIDTH = ColorUtilsHelper.dpToPx(card.getContext(), 2);package com.git.amarradi.leafpad.adapter;

import android.view.LayoutInflater;
import android.view.View;
Expand Down Expand Up @@ -54,7 +54,7 @@ public void setCategories(List<CategoryEntity> categories) {

public void setSelectedCategoryIds(List<Long> ids) {
selectedCategoryIds.clear();
if (ids != null) {
if (null != ids) {
selectedCategoryIds.addAll(ids);
}
notifyDataSetChanged();
Expand Down Expand Up @@ -110,7 +110,7 @@ public void onBindViewHolder(@NonNull CategoryViewHolder holder, int position) {


holder.editButton.setOnClickListener(v -> {
if (listener != null) {
if (null != listener) {
listener.onEditCategory(category);
}
});
Expand All @@ -129,13 +129,13 @@ private void applyCategoryColors(
ImageButton btnDelete,
CategoryEntity category
) {
if (category == null) return;
if (null == category) return;

int baseColor = ColorUtilsHelper.parseCategoryColor(category.colorHex);

int bgColor = ColorUtilsHelper.getCategoryBackgroundColor(baseColor);

card.setStrokeWidth(ColorUtilsHelper.dpToPx(card.getContext(), 2));
card.setStrokeWidth(STROKE_WIDTH);
card.setStrokeColor(baseColor);
card.setCardBackgroundColor(bgColor);

Expand Down