fix: bounded wait in MultiProcContinuousTest to prevent FSDP hang#56
Open
svskvar wants to merge 1 commit into
Open
fix: bounded wait in MultiProcContinuousTest to prevent FSDP hang#56svskvar wants to merge 1 commit into
svskvar wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Prevent/Handle FSDP Hang and instead fail the test with timeout.
Description of changes:
Add a timeout to completion_queue.get() and tear down the worker pool when a rank dies or stalls before sending completion, so a stuck rank can no longer block the test suite forever. A fresh pool is spawned for the next test instead of poisoning the class."
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.