feat: extend ADR detection with additional directory paths and CLAUDE.md partial credit#419
Draft
jwm4 wants to merge 2 commits into
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
✨ Simplify code
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
jeremyeder
force-pushed
the
fix/case-sensitive-lookups-and-gnumakefile
branch
from
5c03fd6 to
77efebe
Compare
jeremyeder
force-pushed
the
fix/case-sensitive-lookups-and-gnumakefile
branch
from
77efebe to
8440e83
Compare
jwm4
force-pushed
the
fix/case-sensitive-lookups-and-gnumakefile
branch
from
8440e83 to
0461eb2
Compare
jwm4
force-pushed
the
feat/adr-extended-paths-and-claude-partial-credit
branch
from
3cde9f1 to
3667f0b
Compare
jwm4
force-pushed
the
fix/case-sensitive-lookups-and-gnumakefile
branch
from
0461eb2 to
960e005
Compare
jwm4
force-pushed
the
feat/adr-extended-paths-and-claude-partial-credit
branch
2 times, most recently
from
11a6b86 to
0455d49
Compare
jwm4
force-pushed
the
fix/case-sensitive-lookups-and-gnumakefile
branch
from
91aa5a4 to
fd2be32
Compare
- architecture_decisions: recognize docs/architecture/, docs/design/, docs/specs/, and specs/ in addition to docs/adr/ variants (closes #414) - architecture_decisions: award 60/100 partial credit when CLAUDE.md or AGENTS.md contains an architecture section or external ADR repo link, with full credit still requiring an inline directory (closes #392) - docs/attributes.md: full write-up for architecture_decisions replacing the one-liner, including scoring table, recognized paths, and partial credit explanation - docs/attributes.md: note GNUmakefile/makefile variants in one_command_setup Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
jwm4
force-pushed
the
feat/adr-extended-paths-and-claude-partial-credit
branch
from
0455d49 to
2a38344
Compare
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
📉 Test Coverage Report
Coverage calculated from unit tests only |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds on #415.
Summary
architecture_decisionsnow recognizesdocs/architecture/,docs/design/,docs/specs/, andspecs/alongside the existingdocs/adr/family — all matched case-insensitivelyCLAUDE.mdorAGENTS.mdcontains an architecture/decisions section heading or a link to an external ADR/RFC repo. Full credit still requires an inline directory, since agents cannot follow external links.architecture_decisionsentry indocs/attributes.mdexpanded from a one-liner to a full write-up with scoring table, recognized paths, and partial credit explanationTest plan
.adr/, CLAUDE.md section detection, AGENTS.md detection, external link detection, and inline-directory-takes-priority behaviorCloses #414, #392
🤖 Generated with Claude Code under the supervision of Bill Murdock