fix: remove hardcoded attribute count limits from assessment schema

[jwm4]

Summary

• Removes maximum: 25 from attributes_assessed, attributes_skipped, attributes_not_assessed, and attributes_total in the assessment JSON schema
• Removes maxItems: 25 from the findings array
• Updates a stale description that referenced the old limit

Why

The validate CI job was failing on all submissions generated by v2.36.1, which produces assessments with 33 attributes. The schema was written when the tool had 25 assessors and was never updated as new ones were added. Hardcoding this limit means the schema breaks every time a new assessor is added.

Test plan

• CI validate job passes on PR Submit assessment for fullsend-ai/fullsend (68.2/100 Silver) #424 after this merges

🤖 Generated with Claude Code under the supervision of Bill Murdock

Summary by CodeRabbit

• Chores
  • Updated validation constraints for assessment data by removing upper bounds on attribute counts and findings collections. The system now supports larger assessment datasets and provides increased flexibility for data capture.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Enterprise

Run ID: 0b84ebc3-132b-4f96-b1f0-04b3d1d7bbd3

📥 Commits

Reviewing files that changed from the base of the PR and between 49b390f and 54456cf.

📒 Files selected for processing (1)

• specs/001-agentready-scorer/contracts/assessment-schema.json

---

📝 Walkthrough

Walkthrough

The PR relaxes upper-bound constraints in assessment-schema.json by removing maximum limits from four numeric properties and maxItems from the findings array, while preserving lower bounds. This removes artificial caps on assessment data.

Changes

Schema Constraint Relaxation

Layer / File(s)	Summary
Assessment schema bounds specs/001-agentready-scorer/contracts/assessment-schema.json	maximum constraints removed from attributes_assessed, attributes_skipped, attributes_not_assessed, and attributes_total; maxItems removed from findings array. Minimum constraints and array item count minimums remain in place. attributes_total description updated for clarity.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title follows Conventional Commits format with 'fix' type and clearly describes the main change: removing hardcoded attribute count limits from the assessment schema.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix/schema-attribute-count-limit

✨ Simplify code

• Create PR with simplified code
• Commit simplified code in branch fix/schema-attribute-count-limit

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[github-actions]

📈 Test Coverage Report

Branch	Coverage
This PR	73.3%
Main	73.3%
Diff	✅ +0%

---

Coverage calculated from unit tests only