-
Notifications
You must be signed in to change notification settings - Fork 106
fix(operator): apply feature flags when scheduled sessions trigger #1572
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
janisz
wants to merge
14
commits into
ambient-code:main
Choose a base branch
from
janisz:fix/scheduled-session-feature-flags
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+184
−24
Open
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
adf081b
fix(operator): apply feature flags when scheduled sessions trigger
janisz 0f878ef
refactor(operator): improve code quality in session trigger
janisz 3526563
Merge branch 'main' into fix/scheduled-session-feature-flags
mergify[bot] 8b8f93f
Merge branch 'main' into fix/scheduled-session-feature-flags
mergify[bot] d1e318c
Merge branch 'main' into fix/scheduled-session-feature-flags
mergify[bot] 3766205
Merge branch 'main' into fix/scheduled-session-feature-flags
mergify[bot] 6212122
Merge branch 'main' into fix/scheduled-session-feature-flags
mergify[bot] 0f9edb0
Merge branch 'main' into fix/scheduled-session-feature-flags
mergify[bot] e688b0b
Merge branch 'main' into fix/scheduled-session-feature-flags
mergify[bot] fcc3f22
Merge branch 'main' into fix/scheduled-session-feature-flags
mergify[bot] 1d3cde4
Merge branch 'main' into fix/scheduled-session-feature-flags
mergify[bot] ab35cd2
Merge branch 'main' into fix/scheduled-session-feature-flags
mergify[bot] 7c9edfe
Merge branch 'main' into fix/scheduled-session-feature-flags
mergify[bot] 513ff9d
Merge branch 'main' into fix/scheduled-session-feature-flags
mergify[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test fixture uses a nested
specshape that does not match runtime input.applyFeatureFlagOverridesis called with the session spec map in production, but this test passes{"spec": {...}}and asserts insidetemplate["spec"]. That can mask real regressions and currently validates the wrong contract.Suggested fix
Also applies to: 195-210
🤖 Prompt for AI Agents