fix: tardises can now properly grow in any dimension properly even if they're locked#1908
Open
fix: tardises can now properly grow in any dimension properly even if they're locked#1908
Conversation
github-actions
bot
added
S: Untriaged
github-actions
bot
added
the
S: Needs Review
Loqor
added
T: Bugfix
github-actions
bot
added
S: Approved
Member
Author
|
yeah should work just fine - im giving it the registry identifier and not the value identifier for the getter of the lockable dim thing, so i think it should be okay? |
Member
|
I just tested it, and it doesn't work. When placing a creative TARDIS in the End or the Nether, then traveling to the same dimension makes the TARDIS refuse to land. Besides that, you can't place down a TARDIS coral on a soul sand in these two dimensions, so only creative TARDISes can be placed. |
Member
|
guh |
github-actions
bot
added
the
S: Awaiting Changes
drtheodor
added
S: Stale
Member
|
updates on this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About the PR
Made the TARDIS auto-unlock a dimension if its grown there.
Why / Balance
To 1. fix issues when growing TARDIS' in other dimensions if locked, and 2. to balance and help players wanting to start in other dimensions.
Technical details
Simply just test for the world and if its lockable and then, unlock it. easy as.
Media
Requirements
Breaking changes
Changelog
🆑