Open
Conversation
Convention is to include system headers first, and local ones last. This
resolves a build issue on centos7:
cc -Isrc/culvert.p -Isrc -I../src -I../src/arch/x86_64 -Isrc/devicetree
-flto -DNDEBUG -pipe -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wextra
-std=gnu99 -O2 -g -MD -MQ src/culvert.p/bridge_devmem.c.o -MF
src/culvert.p/bridge_devmem.c.o.d -o src/culvert.p/bridge_devmem.c.o -c
../src/bridge/devmem.c
In file included from /usr/include/fcntl.h:77:0,
from ../src/bridge/devmem.c:19:
/usr/include/bits/stat.h:106:31: error: expected identifier or '(' before '[' token
__syscall_slong_t __unused[3];
^
Signed-off-by: Joel Stanley <joel@jms.id.au>
Owner
|
Hmm, let me poke at this. I tend to order local includes before system includes so the local headers can adjust the behaviour of system headers as necessary. The fact that re-ordering fixes it feels a bit off? |
Contributor
Author
|
That's generally the opposite of what you should be doing, for this very reason. |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Convention is to include system headers first, and local ones last. This resolves a build issue on centos7:
cc -Isrc/culvert.p -Isrc -I../src -I../src/arch/x86_64 -Isrc/devicetree
-flto -DNDEBUG -pipe -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wextra
-std=gnu99 -O2 -g -MD -MQ src/culvert.p/bridge_devmem.c.o -MF
src/culvert.p/bridge_devmem.c.o.d -o src/culvert.p/bridge_devmem.c.o -c
../src/bridge/devmem.c
In file included from /usr/include/fcntl.h:77:0,
from ../src/bridge/devmem.c:19:
/usr/include/bits/stat.h:106:31: error: expected identifier or '(' before '[' token
__syscall_slong_t __unused[3];
^