Skip to content

Add logging knob to control console output #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
erwei-xilinx merged 5 commits into from
Apr 11, 2026
+28 −15
Merged

Add logging knob to control console output #44

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
832af1a
Replace print() calls with logging module for controllable verbosity
erwei-xilinx Apr 9, 2026
3cdbafc
Fix black formatting: trailing comma on multi-line logger.info call
erwei-xilinx Apr 9, 2026
9964c0b
Address PR review: fix logger default level and avoid global side eff…
erwei-xilinx Apr 9, 2026
c3712fa
Fix black formatting: wrap long logger.debug line
erwei-xilinx Apr 9, 2026
742764c
Address PR review: use CRITICAL default level and error/exception for…
erwei-xilinx Apr 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 28 additions & 15 deletions amd_triton_npu/backend/driver.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@

import hashlib
import json
import logging
import tempfile
import sys
import sysconfig
Expand All @@ -23,6 +24,16 @@
from air.ir import *
import air.passmanager

logger = logging.getLogger(__name__)
logger.setLevel(logging.CRITICAL)
if os.getenv("AMD_TRITON_NPU_DEBUG", "0") == "1":
logger.setLevel(logging.DEBUG)
if not logger.handlers:
_handler = logging.StreamHandler()
_handler.setFormatter(logging.Formatter("%(message)s"))
logger.addHandler(_handler)
logger.propagate = False

autotune_time = False


Expand Down Expand Up @@ -176,10 +187,10 @@ def get_npu_device_info():
return devices

except subprocess.CalledProcessError as e:
print("Failed to run xrt-smi:", e.stderr)
logger.error("Failed to run xrt-smi: %s", e.stderr)
return []
except Exception as e:
print("Unexpected error:", str(e))
logger.exception("Unexpected error during NPU device detection")
return []


Expand Down Expand Up @@ -434,7 +445,7 @@ def _get_transform_ir_string():
f"Use an absolute path or run from the directory containing the script."
)
with open(custom_script_path, "r") as f:
print(f"Using custom tiling script from: {custom_script_path}")
logger.debug("Using custom tiling script from: %s", custom_script_path)
user_script = f.read()
return _inject_transform_library(user_script)

Expand Down Expand Up @@ -1335,28 +1346,30 @@ def launch(

# Check for compile-only mode
if os.getenv("AMD_TRITON_NPU_COMPILE_ONLY", "0") == "1":
print(f"Compile-only mode: binaries cached at {cache_path}")
logger.debug("Compile-only mode: binaries cached at %s", cache_path)
if output_format == "elf":
print(f" elf: {cache_elf_path}")
logger.debug(" elf: %s", cache_elf_path)
else:
print(f" xclbin: {cache_xclbin_path}")
print(f" insts: {cache_insts_path}")
logger.debug(" xclbin: %s", cache_xclbin_path)
logger.debug(" insts: %s", cache_insts_path)
return None
else:
print(
"got cache path: "
+ cache_path
+ " compilation is therefore skipped (delete cache path to force recompile)."
logger.debug(
"got cache path: %s compilation is therefore skipped "
"(delete cache path to force recompile).",
cache_path,
)

# Check for compile-only mode (cache hit)
if os.getenv("AMD_TRITON_NPU_COMPILE_ONLY", "0") == "1":
print(f"Compile-only mode (cache hit): binaries at {cache_path}")
logger.debug(
"Compile-only mode (cache hit): binaries at %s", cache_path
)
if output_format == "elf":
print(f" elf: {cache_elf_path}")
logger.debug(" elf: %s", cache_elf_path)
else:
print(f" xclbin: {cache_xclbin_path}")
print(f" insts: {cache_insts_path}")
logger.debug(" xclbin: %s", cache_xclbin_path)
logger.debug(" insts: %s", cache_insts_path)
return None

# Load and launch the compiled kernel.
Expand Down
Loading