Fixes issue #96 - #100
Conversation
danielholanda
left a comment
There was a problem hiding this comment.
A key part of our behavioral tests is understanding whether or not the description provided by the skill actually makes the LLM trigger it. That said, I understand some of your tests are small "unit" tests of the actual skill instead of only its desctiption.
My recommendation here is the following: Instead of changing the harness:
- Have at least one test where we check whether the agent triggers your skill when it should. Example: You can add the following sentence to the beginning of your
test_launcher_module_writtentest: "Help me turn this python app into an app that targets local llms". - Add
Make sure to use the "local-ai-app-integration" skillto your other tests directly.
https://github.com/amd/skills/pull/100/changes#diff-6e9abf55c55ec3e10d31c015524528d2eab52e678f9f8ad0653264c07ac6e075R33 We are doing a unint test but that alone may not capture. Looking at 2nd suggestion |
@danielholanda This feels a bit like cheating but guarantees to work. |
…arya/fix-issue-96
Root cause
The flakiness is not due to the skill itself but due to the skill not actually getting invoked in the first place.
The agent was never invoking the skill - claude just answered narrow prompts ("write a lemond launcher", "re-point the OpenAI client") entirely from training knowledge.
Changes Summary
skills/local-ai-app-integration/evals/evals.py
local AI / local backend", single logs_contains("local-ai-app-integration") check only
logs_contains("local-ai-app-integration") as first assertion
skills/local-ai-app-integration/SKILL.md
subprocess.Popen(...), GET /api/v1/health
skills/local-ai-app-integration/reference.md