leverage go-git to ignore file instead of custom solution#201
Open
carlosmarte wants to merge 1 commit into
Open
leverage go-git to ignore file instead of custom solution#201carlosmarte wants to merge 1 commit into
carlosmarte wants to merge 1 commit into
Conversation
carlosmarte
commented
Jan 27, 2026
carlosmarte
commented
- Directory patterns: pycache/ should match files inside the directory, but the simple matcher doesn't understand this
- Basename matching: .env pattern should match config/.env but the exact matcher requires full path matching
- Pattern complexity: Many gitignore patterns like *.py[codz] and directory traversal patterns fail
carlosmarte
requested review from
grinish21,
nsc5171 and
utsavmaniyar
as code owners
|
|
carlosmarte
force-pushed
the
feat/use-go-git-ignore
branch
2 times, most recently
from
4206560 to
0cc8102
Compare
carlosmarte
force-pushed
the
feat/use-go-git-ignore
branch
from
0cc8102 to
10c330d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.